search

numaproj / numaflow-python

Numaflow Python SDK
Apache License 2.0
52 stars 18 forks source link

chore: write server info for sideinput sdk #130

Closed ayildirim21 closed 8 months ago

ayildirim21 commented 8 months ago

Implements: Issue 1457 for the Python sdk

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (39ec103) 95.15% compared to head (015c32c) 95.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #130 +/- ## ======================================= Coverage 95.15% 95.15% ======================================= Files 45 45 Lines 1424 1424 Branches 81 81 ======================================= Hits 1355 1355 Misses 50 50 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kohlisid commented 8 months ago

We are about to merge https://github.com/numaproj/numaflow-python/pull/129 Could wait for merging this in till that, might want to rebase on top of it as it has many changes

kohlisid commented 8 months ago

@a3hadi Please run lint on your codebase once and re-upload It can be done by the command from project base directory make lint