numaproj / numaflow-python

Numaflow Python SDK
Apache License 2.0
52 stars 18 forks source link

feat: implement reduce streaming #134

Closed kohlisid closed 6 months ago

kohlisid commented 7 months ago

Fixes #1546

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 94.51697% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 95.08%. Comparing base (afa6970) to head (87ccdfc). Report is 1 commits behind head on main.

Files Patch % Lines
pynumaflow/reducestreamer/servicer/task_manager.py 91.15% 5 Missing and 5 partials :warning:
pynumaflow/reducestreamer/async_server.py 84.37% 3 Missing and 2 partials :warning:
...numaflow/reducestreamer/servicer/async_servicer.py 92.15% 3 Missing and 1 partial :warning:
pynumaflow/reducestreamer/_dtypes.py 98.80% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ========================================== - Coverage 95.24% 95.08% -0.16% ========================================== Files 46 51 +5 Lines 1513 1893 +380 Branches 83 116 +33 ========================================== + Hits 1441 1800 +359 - Misses 51 64 +13 - Partials 21 29 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kohlisid commented 7 months ago

Tested using E2E

--- PASS: TestSessionSuite (206.24s)
    --- PASS: TestSessionSuite/TestReduceStreamPython (104.32s)
PASS
ok      github.com/numaproj/numaflow/test/reduce-two-e2e        206.838s
vigith commented 7 months ago

@ab93 please review, we need this for the Monday release.