search

numaproj / numaflow-python

Numaflow Python SDK
Apache License 2.0
52 stars 18 forks source link

chore: UDS based multiproc #162

Closed kohlisid closed 5 months ago

kohlisid commented 5 months ago

Transition the multiproc servers to use UDS sockets instead of TCP Fixes #161

We can see equal CPU usage between the servers

Screenshot 2024-04-24 at 10 33 07 AM
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.98%. Comparing base (2a0d65d) to head (bb16d12).

Files Patch % Lines
pynumaflow/reducestreamer/servicer/task_manager.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ========================================== - Coverage 94.99% 94.98% -0.01% ========================================== Files 52 52 Lines 1957 1956 -1 Branches 120 120 ========================================== - Hits 1859 1858 -1 Misses 69 69 Partials 29 29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ab93 commented 5 months ago

Can we do anything about the patch diff here? @kohlisid

kohlisid commented 5 months ago

@ab93 That is related to due to the coverage of one exception handler for a condition which is slightly difficult to replicate through UT. I will see if I can add some test there in the other PR