Closed ayildirim21 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.65%. Comparing base (
02009c8
) to head (5ff7370
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ayildirim21 Does this support building directly from examples right now? Or would need to fork the whole repo
@ayildirim21 Does this support building directly from examples right now? Or would need to fork the whole repo
Right now still need to fork the entire repo, this change was just to get rid of the hacky solution of needing to build the tarball first before building the image. We're still tracking the broader issue at #1658. If we're ok with not using local references, and instead using the remote git repo as the dependency in the toml file, then we can support directly buidling from examples though.
How was this change tested?
How was this change tested?
ran make image for all the examples to ensure that the image was being built properly.
Previously to make local references work, we had to run an extra command in order to build a tarball of the SDK. While working on automation for the rust sdk, I found that we can just switch the build context to the root directory, and build our examples from there, thereby no longer requiring the extra step of building the tarball.