numaproj / numaflow-python

Numaflow Python SDK
Apache License 2.0
50 stars 17 forks source link

fix: modify Dockerfiles to fix failing image builds #180

Closed ayildirim21 closed 1 month ago

ayildirim21 commented 1 month ago

Kindly explain what this PR does.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.65%. Comparing base (b847504) to head (2599b18).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #180 +/- ## ======================================= Coverage 94.65% 94.65% ======================================= Files 52 52 Lines 2003 2003 Branches 119 119 ======================================= Hits 1896 1896 Misses 78 78 Partials 29 29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kohlisid commented 1 month ago

@ayildirim21 Tested with images running?

ayildirim21 commented 1 month ago

@ayildirim21 Tested with images running?

I ran several of the example pipelines locally, after pushing their respective images, and did not come across any errors in the container logs

kohlisid commented 1 month ago

@ayildirim21 Please do verify both approaches once, default and with args in the yaml Thanks!

ayildirim21 commented 1 month ago

@kohlisid Ran the even-odd example with both

container:
  args:
  - python
  - example.py

Present and not, both pipelines ran fine

kohlisid commented 1 month ago

Thanks @ayildirim21