Closed jy4096 closed 1 year ago
Merging #23 (d357590) into main (c3b1a80) will increase coverage by
0.14%
. The diff coverage is71.42%
.:exclamation: Current head d357590 differs from pull request most recent head 4c47e1d. Consider uploading reports for the commit 4c47e1d to get more accurate results
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 87.31% 87.45% +0.14%
==========================================
Files 6 6
Lines 268 271 +3
Branches 13 13
==========================================
+ Hits 234 237 +3
Misses 32 32
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
pynumaflow/function/server.py | 70.68% <66.66%> (+0.51%) |
:arrow_up: |
pynumaflow/sink/server.py | 67.30% <66.66%> (+0.64%) |
:arrow_up: |
pynumaflow/_constants.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Signed-off-by: jyu6 juanlu_yu@intuit.com
https://github.com/numaproj/numaflow/issues/299
Tested using numaflow-go gRPC client and numaflow-python gPRC server.
Main branch: if receive something larger than the default 4 MB limit, we will see the following error.
Current branch: add the option to set a higher max message size limit. (socket path field is set for testing purpose)
and the tests succeed.
TODO
Need help on the codecov... thank you