numaproj / numaflow-python

Numaflow Python SDK
Apache License 2.0
53 stars 18 forks source link

chore: update protobuf version #56

Closed sandangel closed 1 year ago

sandangel commented 1 year ago

Signed-off-by: San Nguyen vinhsannguyen91@gmail.com

Kindly explain what this PR does.

sandangel commented 1 year ago

there should be no breaking change https://protobuf.dev/support/migration/

codecov[bot] commented 1 year ago

Codecov Report

Merging #56 (2bdee8e) into main (226529f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          10       10           
  Lines         343      343           
  Branches       26       26           
=======================================
  Hits          330      330           
  Misses          8        8           
  Partials        5        5           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sandangel commented 1 year ago

But numaflow-sdk should not depends on numalogic right?

vigith commented 1 year ago

But numaflow-sdk should not depends on numalogic right?

that is right