search

numaproj / numaflow-python

Numaflow Python SDK
Apache License 2.0
53 stars 18 forks source link

fix: store strong references of task objects #66

Closed kohlisid closed 1 year ago

kohlisid commented 1 year ago

Fixes #63 Save strong references of tasks/futures so that they are not lost mid execution due to GC.

codecov[bot] commented 1 year ago

Codecov Report

Merging #66 (6598e25) into main (3e81304) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   96.94%   96.97%   +0.03%     
==========================================
  Files          11       11              
  Lines         425      430       +5     
  Branches       32       34       +2     
==========================================
+ Hits          412      417       +5     
  Misses          8        8              
  Partials        5        5
Impacted Files Coverage Δ
pynumaflow/function/server.py 93.54% <100.00%> (+0.27%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

KeranYang commented 1 year ago

@kohlisid FYI. The codecov failure could be resolved by https://github.com/numaproj/numaflow-python/pull/67#discussion_r1138831711