feat: Add ID and numDelivered fields to Datum in udf

xdevxy commented 1 year ago

As part of https://github.com/numaproj/numaflow/issues/538, this PR adds ID and numDelivered fields to Datum in udf, so that users are exposed with these metadata information about the message.

codecov[bot] commented 1 year ago

Codecov Report

Merging #77 (70963bd) into main (1849f10) will decrease coverage by 0.12%. The diff coverage is 95.23%.

:exclamation: Current head 70963bd differs from pull request most recent head f02b80e. Consider uploading reports for the commit f02b80e to get more accurate results

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   97.68%   97.56%   -0.12%     
==========================================
  Files          12       12              
  Lines         475      493      +18     
  Branches       33       33              
==========================================
+ Hits          464      481      +17     
- Misses          6        7       +1     
  Partials        5        5

Impacted Files	Coverage Δ
pynumaflow/sink/_dtypes.py	`98.33% <ø> (ø)`
pynumaflow/function/_dtypes.py	`98.87% <95.00%> (-0.51%)`	:arrow_down:
pynumaflow/function/server.py	`97.56% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

vigith commented 1 year ago

can you run make lint, i feel few changes can be removed if we run the linter.

xdevxy commented 1 year ago

can you run make lint, i feel few changes can be removed if we run the linter. I thought I had, but somehow I missed it.. updated. :)

xdevxy commented 1 year ago

should we document this in README?

Sure, will have a follow up PR.

numaproj / numaflow-python

feat: Add ID and numDelivered fields to Datum in udf #77

Codecov Report