numaproj / numaflow

Kubernetes-native platform to run massively parallel data/streaming jobs
https://numaflow.numaproj.io/
Apache License 2.0
1.09k stars 111 forks source link

chore: reduce 5 second wait time every time redis sink check runs in e2e #2023

Closed KeranYang closed 4 weeks ago

KeranYang commented 4 weeks ago

We use a 5s ticker to retry redis check in e2e, the check start with waiting for 5s before the first check, adding a lot of unnecessary wait time. Especially in test cases where we call multiple redis checks. This change immediately checks to reduce the 5 second wait.

Before the change:

--- PASS: TestDiamondSuite (482.58s)
    --- PASS: TestDiamondSuite/TestCycleBackward (119.63s)
    --- PASS: TestDiamondSuite/TestCycleToSelf (118.82s)
    --- PASS: TestDiamondSuite/TestJoinOnMapPipeline (69.46s)
    --- PASS: TestDiamondSuite/TestJoinOnReducePipeline (71.50s)
    --- PASS: TestDiamondSuite/TestJoinOnSinkVertex (69.61s)

After:

--- PASS: TestDiamondSuite (365.96s)
    --- PASS: TestDiamondSuite/TestCycleBackward (69.73s)
    --- PASS: TestDiamondSuite/TestCycleToSelf (68.09s)
    --- PASS: TestDiamondSuite/TestJoinOnMapPipeline (62.44s)
    --- PASS: TestDiamondSuite/TestJoinOnReducePipeline (68.53s)
    --- PASS: TestDiamondSuite/TestJoinOnSinkVertex (62.69s)
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.74%. Comparing base (1588175) to head (c0462c3). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2023 +/- ## ========================================== - Coverage 61.76% 61.74% -0.02% ========================================== Files 318 318 Lines 28822 28822 ========================================== - Hits 17801 17797 -4 - Misses 10070 10076 +6 + Partials 951 949 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.