Closed juliev0 closed 2 months ago
Attention: Patch coverage is 50.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 63.80%. Comparing base (
ed543ad
) to head (498f5bf
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/reconciler/pipeline/controller.go | 50.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It seems if you create a Pipeline with no
metadata.annotations
set (at least if you are using minimized CRDs), then trying to do this json patch operation fails with the error "the server rejected our request due to an error in our request".This does not happen if a Merge Patch is used instead.
I tested this in the case of:
For both cases, I experimented with adding
lifecycle.desiredPhase: Paused
and also with removing it.For both, I observed the proper annotation set:
...and then later removed.