numaproj / numaflow

Kubernetes-native platform to run massively parallel data/streaming jobs
https://numaflow.numaproj.io/
Apache License 2.0
1.1k stars 112 forks source link

Kafa sink not retaining the key value. #2142

Closed vegesana closed 1 week ago

vegesana commented 1 week ago

Describe the bug I added key to my message (kafka usecase) in UDF vertex as part of mapping. I pinned two sink vertices to the UDF - one to sink log and one to kafka sink.

To Reproduce Steps to reproduce the behavior:

1) Send message to kafka sink via UDF with key value set for the message. 2) Check the message on hte kafka topic on to which the kafka sink is sending. 3) Key is not present.

Expected behavior Need key value to be ratained by the kafka sink. Else with multiple partitions in kafka topic will cause out of order situations

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

For quick help and support, join our slack channel.

vigith commented 1 week ago

how do you want the keys to be added to the header? keys is an array, while header is key/value.

vegesana commented 1 week ago

Thats true.. when i started making changes to fix this, even i realized it. Like addkeys() and addtags() for messages, we might need to add addHeaders() api as well. For key, we might need to add new field in the header. That is my opinion which i am planning to tryOn Oct 10, 2024, at 7:55 PM, Vigith Maurice @.***> wrote: how do you want the keys to be added to the header? keys is an array, while header is key/value.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

vigith commented 1 week ago

closed via #2143 2143