numaproj / numalogic-prometheus

AIOps for metrics in Prometheus
Apache License 2.0
32 stars 10 forks source link

feat: env vars to config #125

Closed nkoppisetty closed 1 year ago

nkoppisetty commented 1 year ago

Explain what this PR does.

Moved env vars for Redis, Prometheus and MLflow to config, to avoid human errors when configuring the pipeline yaml

codecov-commenter commented 1 year ago

Codecov Report

Merging #125 (cd84582) into main (d75cd12) will decrease coverage by 0.10%. The diff coverage is 87.32%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   83.67%   83.57%   -0.10%     
==========================================
  Files          20       20              
  Lines        1084     1108      +24     
  Branches      116      121       +5     
==========================================
+ Hits          907      926      +19     
- Misses        153      157       +4     
- Partials       24       25       +1     
Impacted Files Coverage Δ
numaprom/_constants.py 100.00% <ø> (ø)
numaprom/clients/sentinel.py 88.88% <ø> (ø)
numaprom/udsink/train.py 57.89% <66.66%> (-1.71%) :arrow_down:
numaprom/watcher.py 67.82% <69.56%> (+1.15%) :arrow_up:
numaprom/udsink/train_rollout.py 84.21% <75.00%> (-0.54%) :arrow_down:
numaprom/__init__.py 85.00% <100.00%> (ø)
numaprom/_config.py 100.00% <100.00%> (ø)
numaprom/tools.py 85.80% <100.00%> (-0.10%) :arrow_down:
numaprom/udf/inference.py 95.38% <100.00%> (ø)
numaprom/udf/postprocess.py 95.55% <100.00%> (-0.10%) :arrow_down:
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more