search

numaproj / numalogic-prometheus

AIOps for metrics in Prometheus
Apache License 2.0
32 stars 10 forks source link

fix: catch inference errors and send for static thresholding #126

Closed ab93 closed 1 year ago

ab93 commented 1 year ago

Previously if there were any config changes, or inference errors the exception will be unhandled. This change makes sure that if that happens,

  1. Perform static thresholding
  2. Send for retraining
codecov-commenter commented 1 year ago

Codecov Report

Merging #126 (6fa37ba) into main (1c9d7c7) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   83.50%   83.67%   +0.16%     
==========================================
  Files          20       20              
  Lines        1073     1084      +11     
  Branches      116      116              
==========================================
+ Hits          896      907      +11     
  Misses        153      153              
  Partials       24       24
Impacted Files Coverage Δ
numaprom/entities.py 95.55% <100.00%> (+0.04%) :arrow_up:
numaprom/udf/inference.py 95.38% <100.00%> (+0.83%) :arrow_up:
numaprom/udf/threshold.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more