search

numaproj / numalogic-prometheus

AIOps for metrics in Prometheus
Apache License 2.0
32 stars 10 forks source link

fix: prometheus fetcher #147

Closed nkoppisetty closed 1 year ago

nkoppisetty commented 1 year ago

Explain what this PR does.

Added changes for fixing prometheus fetcher when fetching multiple time series. Every new label for metric is considered a new time series, and results in multiple metrics while fetching.

codecov-commenter commented 1 year ago

Codecov Report

Merging #147 (d171043) into main (e414a5d) will increase coverage by 0.39%. The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   82.30%   82.70%   +0.39%     
==========================================
  Files          20       20              
  Lines        1136     1139       +3     
  Branches      119      120       +1     
==========================================
+ Hits          935      942       +7     
+ Misses        177      174       -3     
+ Partials       24       23       -1
Impacted Files Coverage Δ
numaprom/clients/prometheus.py 71.62% <82.75%> (+6.83%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more