numaproj / numalogic-prometheus

AIOps for metrics in Prometheus
Apache License 2.0
31 stars 10 forks source link

fix: thresh bug when there is RedisRegistryError #164

Closed s0nicboOm closed 12 months ago

s0nicboOm commented 12 months ago

When Thresh model load fails (ModelRegistryError), we are getting stuck in the loop. The PR introduces a fix

codecov-commenter commented 12 months ago

Codecov Report

Merging #164 (45ce3af) into main (1eafb0d) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          18       18           
  Lines        1119     1119           
  Branches      118      118           
=======================================
  Hits          965      965           
  Misses        130      130           
  Partials       24       24           
Files Changed Coverage Δ
numaprom/udf/threshold.py 92.18% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more