numaproj / numalogic

Collection of operational time series ML models and tools
https://numalogic.numaproj.io/
Apache License 2.0
166 stars 28 forks source link

add: redis registry #170

Closed s0nicboOm closed 1 year ago

s0nicboOm commented 1 year ago

Explain what this PR does.

Introduces Redis Registry.

Doc: https://docs.google.com/document/d/1NkeUzBwg_d_RYh35zqEEwIEIrE7WjcyNWYkJPQUfi5g/edit

Note: 1) Have not updated pyproject.toml yet 2) Serialization technique to be added later

codecov[bot] commented 1 year ago

Codecov Report

Merging #170 (3e14254) into main (794ddc6) will increase coverage by 0.15%. The diff coverage is 99.27%.

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   97.03%   97.19%   +0.15%     
==========================================
  Files          34       36       +2     
  Lines        1351     1463     +112     
  Branches      102      111       +9     
==========================================
+ Hits         1311     1422     +111     
- Misses         29       30       +1     
  Partials       11       11              
Impacted Files Coverage Δ
numalogic/registry/redis_registry.py 98.93% <98.93%> (ø)
numalogic/config/__init__.py 100.00% <100.00%> (ø)
numalogic/config/_config.py 100.00% <100.00%> (ø)
numalogic/config/factory.py 100.00% <100.00%> (ø)
numalogic/registry/__init__.py 75.00% <100.00%> (+3.57%) :arrow_up:
numalogic/registry/_serialize.py 100.00% <100.00%> (ø)
numalogic/registry/artifact.py 93.02% <100.00%> (-0.46%) :arrow_down:
numalogic/registry/mlflow_registry.py 83.94% <100.00%> (-0.12%) :arrow_down:
numalogic/tools/exceptions.py 100.00% <100.00%> (ø)
numalogic/tools/types.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

s0nicboOm commented 1 year ago

Some comments

Fixed