numaproj / numalogic

Collection of operational time series ML models and tools
https://numalogic.numaproj.io/
Apache License 2.0
166 stars 28 forks source link

feat: support both base conf and app conf #328

Closed ab93 closed 10 months ago

ab93 commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c967f20) 94.19% compared to head (6c99575) 93.78%. Report is 1 commits behind head on main.

Files Patch % Lines
numalogic/udfs/trainer/_prom.py 60.00% 14 Missing :warning:
numalogic/connectors/redis.py 33.33% 1 Missing and 1 partial :warning:
numalogic/udfs/__main__.py 87.50% 1 Missing :warning:
numalogic/udfs/trainer/_base.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #328 +/- ## ========================================== - Coverage 94.19% 93.78% -0.42% ========================================== Files 76 79 +3 Lines 3482 3570 +88 Branches 282 292 +10 ========================================== + Hits 3280 3348 +68 - Misses 157 176 +19 - Partials 45 46 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sarabala1979 commented 10 months ago

@ab93 Will Code load the new file if there is a config change? similar https://github.com/numaproj/numalogic-prometheus/pull/119

ab93 commented 10 months ago

@ab93 Will Code load the new file if there is a config change? similar numaproj/numalogic-prometheus#119

@sarabala1979 no it won't here. Added a new issue to track it.