Closed ab93 closed 8 months ago
Attention: 57 lines
in your changes are missing coverage. Please review.
Comparison is base (
2d84876
) 93.40% compared to head (644875d
) 92.31%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Have you evaluated the quality difference between plain VAE v.s. conv1d VAE in anomaly detection?
Yes, conv1d has much better quantitative scores.
Also, I am not sure how do we test pytest files. can you add a step in README for it too.
Added some minor comments otherwise LGTM.
Simple make test
will work, already in README.
Additions:
Removal: