numaproj / numalogic

Collection of operational time series ML models and tools
https://numalogic.numaproj.io/
Apache License 2.0
166 stars 28 forks source link

Refactor logging in UDFs #356

Closed gulshan02 closed 6 months ago

gulshan02 commented 6 months ago

Explain what this PR does.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.68%. Comparing base (db2cc4f) to head (397ce4e). Report is 4 commits behind head on main.

:exclamation: Current head 397ce4e differs from pull request most recent head f275c90. Consider uploading reports for the commit f275c90 to get more accurate results

Files Patch % Lines
numalogic/udfs/postprocess.py 81.81% 2 Missing :warning:
numalogic/udfs/payloadtx.py 83.33% 1 Missing :warning:
numalogic/udfs/staticthresh.py 88.88% 1 Missing :warning:
numalogic/udfs/tools.py 95.83% 1 Missing :warning:
numalogic/udfs/trainer/_prom.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #356 +/- ## ======================================= Coverage 92.67% 92.68% ======================================= Files 83 84 +1 Lines 4080 4099 +19 Branches 352 352 ======================================= + Hits 3781 3799 +18 - Misses 223 224 +1 Partials 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

s0nicboOm commented 6 months ago

Can we also add logs for trainer/base.py

gulshan02 commented 6 months ago

Can we also add logs for trainer/base.py

Added logs for trainer/base.py