numaproj / numalogic

Collection of operational time series ML models and tools
https://numalogic.numaproj.io/
Apache License 2.0
166 stars 28 forks source link

pipeline examples/multi_udf/numa-pl.yaml in main branch does not conform to the pipeline CRD #396

Open gopaljayanthi opened 4 months ago

gopaljayanthi commented 4 months ago

Describe the bug pipeline examples/multi_udf/numa-pl.yaml in main branch has .spec.edges[3].conditions is wrong, it has keyIn field where as the CRD requires tags field To Reproduce

  1. git clone https://github.com/numaproj/numalogic.git
  2. cd numalogic
  3. kubectl apply -f examples/multi_udf/numa-pl.yaml

Expected behavior pipeline should be created

Screenshots k apply -f https://raw.githubusercontent.com/numaproj/numalogic/main/examples/multi_udf/numa-pl.yaml deployment.apps/mlflow-sqlite created service/mlflow-service created Error from server (BadRequest): error when creating "https://raw.githubusercontent.com/numaproj/numalogic/main/examples/multi_udf/numa-pl.yaml": Pipeline in version "v1alpha1" cannot be handled as a Pipeline: strict decoding error: unknown field "spec.edges[3].conditions.keyIn", unknown field "spec.edges[4].conditions.keyIn"

Environment (please complete the following information):

Additional context using docker-dektop on windows 10 with ubuntu 18.04 vm as the kubernetes


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

ab93 commented 4 months ago

Hi @gopaljayanthi thanks for bringing this on our attention. Will test and update it soon.

naveenkumarsp commented 3 months ago

I am facing diffrent issue when i tried applying numa-pl.yaml.

Error from server (BadRequest): error when creating "https://raw.githubusercontent.com/numaproj/numalogic/main/examples/multi_udf/numa-pl.yaml": admission webhook "webh
ook.numaflow.numaproj.io" denied the request: invalid vertex "train", UDF must have to and from edges