search

numaproj / numalogic

Collection of operational time series ML models and tools
https://numalogic.numaproj.io/
Apache License 2.0
166 stars 28 forks source link

fix: test_mlflow_registry #412

Closed yleilawang closed 1 month ago

yleilawang commented 1 month ago

There existed errors in test logs while test cases still passed. One example is the ConnectionError due to not mocking mlflow function calls properly.

Fixed through modifying a few syntax for patch mock calls. The test cases should pass with no logging errors now.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (f6ce546) to head (0906086).

Files with missing lines Patch % Lines
numalogic/registry/mlflow_registry.py 94.73% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #412 +/- ## ========================================== + Coverage 92.18% 92.22% +0.03% ========================================== Files 97 97 Lines 4775 4811 +36 Branches 429 434 +5 ========================================== + Hits 4402 4437 +35 + Misses 276 275 -1 - Partials 97 99 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yleilawang commented 1 month ago

not needed, new PR created.