search

numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
13 stars 2 forks source link

Fix - ConfigMap changes - `logLevel` and `includedResources` should propagate to gitops-engine #10

Open juliev0 opened 6 months ago

juliev0 commented 6 months ago

Now that we have a callback mechanism for when the ConfigMap changes, we can use it to update these values in the gitops-engine

juliev0 commented 4 months ago

I think we may need to call getCluster() if either of these values change.

If includedResources changes, this call to loadCacheSettings() would have a different result. If logLevel changes, we need to pass this in again.

As part of this PR, make sure that if you modify those values, everything is still working correctly.