search

numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
7 stars 4 forks source link

Ensure draining is always complete with best effort #124

Open xdevxy opened 1 month ago

xdevxy commented 1 month ago

Summary

We need to make the default value as unlimited or large time (e.g. 30 mins) to always wait for the draining is complete or timeout in upper level.

Optionally We may want to provide an option to indicate some of the pipeline may needs longer time to complete drain as numaflow has such option via spec.lifecycle.pauseGracePeriodSeconds.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

juliev0 commented 1 month ago

I wonder if it makes sense for Numalego to provide that option and then they include it in the Rollout's Pipeline Spec directly?

juliev0 commented 3 weeks ago

Discussed with Derek and we agreed that within Intuit we can have a larger value by default - this can be indicated on the Paved Path side. I will write up an issue there

juliev0 commented 3 weeks ago

https://github.intuit.com/oss-analytics/numaportal/issues/301