search

numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
7 stars 4 forks source link

Make sure PPND will be okay with the latency of Pipeline/ISBService informers #232

Open juliev0 opened 1 week ago

juliev0 commented 1 week ago

this is based on this comment

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

juliev0 commented 1 week ago

I came up with at least one case where it wouldn't be good: once PipelineRollout Reconciler has update the Pipeline spec, it will check to see if the Pipeline is still reconciling in order to know whether it can resume the Pipeline or not. If we get an old copy of the Pipeline spec whose generation still shows the previous generation, then its observedGeneration would in fact match the generation, and then we'd resume the Pipeline prematurely.

For this reason, I think if we currently have the PPND InProgressStrategy (saved in memory), then we should reach out to the K8S API to get the latest spec rather than just using the one from the Informer.