search

numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
12 stars 1 forks source link

chore: add a hash suffix based on the spec for pipeline #244

Closed xdevxy closed 1 month ago

xdevxy commented 2 months ago

Fixes #243

Modifications

Since we may have multiple pipelines associate with a pipeline rollout soon for the no downtime upgrade feature. This PR adds the logic to uniquely identify a pipeline that associate with a pipeline rollout based on its spec. To deterministic identify a pipeline, added a hash of the pipeline spec as a suffix to the name of the pipeline.

This PR also fixes a bug that when a pipeline with the same name already exist without a pipeline Rollout manage it. It should update the phase to failed without checking the child status.

Verification

make test
make test-e2e
juliev0 commented 2 months ago

hmm, looks like e2e failed?

xdevxy commented 2 months ago

Decided to postponed this PR as it can introduce the issue that multiple pipelines associate with a pipelineRollout after a spec change.