search

numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
8 stars 4 forks source link

Remove nil checking from pipeline comparison after Numaflow changes its Finalizer updating to patch #246

Closed juliev0 closed 2 hours ago

juliev0 commented 2 weeks ago

Describe the bug We currently have logic which checks if the Pipeline or ISBSvc has changed in order to know what to do. When Numaflow Controller adds the finalizer it can add additional fields. This could result in an incorrect comparison result.

Document here: https://docs.google.com/document/d/1BfaDP4mf5QxBhttNP32p2X09YyhbS-9KsuyjR_Qt8c8/edit#heading=h.9032mlsdcybz

Numaflow will resolve this by patching the finalizer rather than updating the Pipeline directly. Once it does, we can remove all of this nil checking.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

juliev0 commented 2 weeks ago

Numaflow issue: https://github.com/numaproj/numaflow/issues/2054