numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
13 stars 2 forks source link

chore: print message when configmaps change; remove outdated fields from configmap that's run locally #381

Closed juliev0 closed 3 weeks ago

juliev0 commented 3 weeks ago

Modifications

I noticed we weren't printing anything when the configmaps change. I'm guessing people decided not to because there's a cyclical dependency caused if you try to use the logger, which depends on the config module. I decided to just add fmt.Printf statements in that case.

Second, I also noticed there were some outdated fields in the configmap we're applying when we run make start (from original Numaplane), so I removed them.

Verification

Updated ConfigMaps and verified I saw the changes reflected in the log.