We will need to start to test the Progressive logic.
I have these 2 options in mind:
Add "Progressive" as one variety of the current functional_test.go. Just like ppnd, we'd have some logic in there that's conditionally performed only in the case of progressive
Have a separate file altogether, and rename functional_test.go to in_place_update_test.go or something (both "ppnd" and "no strategy" both test updates that are in place, unlike progressive). In this case, we want to avoid a bunch of copy/pasting, and instead create more reusable functions that are shared between this and the progressive test. Note I've been thinking that once we have multiple test files, we may want to incorporate the suite_test.go code directly in the test code file.
Option 2
Update: I think we probably should go with Option 2 after all. This is because Progressive is going to use 2 NumaflowControllerRollouts, so it's different.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
Summary
We will need to start to test the Progressive logic.
I have these 2 options in mind:
functional_test.go. Just likeppnd, we'd have some logic in there that's conditionally performed only in the case ofprogressivefunctional_test.gotoin_place_update_test.goor something (both "ppnd" and "no strategy" both test updates that are in place, unlike progressive). In this case, we want to avoid a bunch of copy/pasting, and instead create more reusable functions that are shared between this and the progressive test. Note I've been thinking that once we have multiple test files, we may want to incorporate thesuite_test.gocode directly in the test code file.Option 2
Update: I think we probably should go with Option 2 after all. This is because Progressive is going to use 2 NumaflowControllerRollouts, so it's different.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.