search

numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
13 stars 2 forks source link

feat: add option to override defaultStrategy with noStrategy #394

Closed dpadhiar closed 2 weeks ago

dpadhiar commented 2 weeks ago

Fixes #386

Modifications

Allows user to specify no-strategy as a valid option for upgrade strategy in the user namespace config.

Previously we viewed empty string as specifying no-strategy but now we look for this to be specifically to override the current setting.

Verification

Running PPND=true make start and testing with a namespace config that says no-strategy

Watched that the Pipeline we updated did not pause when changes were applied to the rollout.

dpadhiar commented 2 weeks ago

@juliev0 Everything is passing except the title check. I think this is because of the permissions change going for public to private, unsure if we need to update the repo settings or update the CI yaml.