numaproj / numaplane

Control Plane for Numaproj
Apache License 2.0
13 stars 2 forks source link

fix: PausingPipelines Condition should get set upon next reconciliation if there's a failure #424

Closed juliev0 closed 3 days ago

juliev0 commented 3 days ago

Fixes #421

Modifications

Previously, we had to be in the middle of the "ppnd" in-progress-strategy in order to unset the "PausingPipelines" Conditions. I moved the setting/unsetting of that Condition to the same place where we process Child Health conditions, which is called by the Reconcile() function every time (regardless of whether a failure occurred previously). This ensures that we set it.

Verification

Ran e2e test through CI.