numaru / vscode-ceedling-test-adapter

Ceedling Test Adapter for the VS Code Test Explorer
MIT License
37 stars 13 forks source link

Coloured output is not handled #102

Closed lipi closed 2 years ago

lipi commented 2 years ago

When enabling Unity's coloured_report plugin, which turns pass/fail results green/red, the test explorer's output doesn't handle the control characters:

image

Expected behaviour: at least it should remove the control characters from the output. Ideally it would colour the output properly.

Note, that VSCode's terminal does handle the colours properly:

image
numaru commented 2 years ago

👍 Thank you for the clear report. I will have a look!

numaru commented 2 years ago

After a quick investigation. The text is given to the output panel GUI using a vscode.OutputChannel. And adding the ascii color support to the native output panel has been removed from the vscode roadmap. But you can use for the IBM/output-colorizer extension to add ascii color to the output.

What I can do is: remove the escape codes by default and add a settings option to re-enable them if you use a third-party extension like the IBM one.

lipi commented 2 years ago

I have tried the IBM plugin but it seems to add extra coloring for certain keywords, it does not improve on the original issue.

image
numaru commented 2 years ago

Oups, my bad :facepalm: I tested the extension really quick and I lost myself. But, we can now remove the escape codes in any case :smile:

numaru commented 2 years ago

It should be now fixed in the new 1.10.0 release