numaru / vscode-ceedling-test-adapter

Ceedling Test Adapter for the VS Code Test Explorer
MIT License
37 stars 14 forks source link

Add support for debug tests with specific defines #43

Closed CezaryGapinski closed 4 years ago

CezaryGapinski commented 4 years ago

When specific preprocessor defines for tests are specified, executable is placed in subdirectory named like test file without extension. This should solve issue #42

numaru commented 4 years ago

Good job and thanks for this contribution!

I prefer this implementation over the one described in the issue. The only caveat is that it breaks the debug on earlier version of ceedling. I think the one I'm using to test does not implement this behavior.

> ceedling version
Welcome to Ceedling!
  Ceedling::   0.28.3
  CMock::      2.4.5
  Unity::      2.4.2
  CException:: 1.3.1

I will add a check of the ceedling version before releasing the extension.

CezaryGapinski commented 4 years ago

Thanks! I think this feature was implemented two years ago and should be available in 0.28.3. I guess I know why it doesn't work for you :). There was an another bug in ceedling. TestAdcHardware what I described in issue #42 is not placed in subdirectory because is not detected by ceedling as a test with specific defines and was compiled in standard way.

Sorry that I didn't mention about ceedling version in this issue.

You can try my dirty example from here where I have tests files with prefix test_ and should show you an issue :). Just create the new ceedling project and copy and paste src, test and project.yml from this example.

numaru commented 4 years ago

Ho, I though it was a new feature and not a bugfix. Let's keep your implementation then 👌