search

numaru / vscode-ceedling-test-adapter

Ceedling Test Adapter for the VS Code Test Explorer
MIT License
37 stars 13 forks source link

Be able to use TEST_VALUE instead of TEST_CASE (https://github.com/ThrowTheSwitch/Ceedling/issues/195) #91

Closed olowo726 closed 2 years ago

olowo726 commented 2 years ago

We have to use the workaround described at https://github.com/ThrowTheSwitch/Ceedling/issues/195. There is a solution to avoid this workaround (https://github.com/ThrowTheSwitch/Ceedling/pull/497) but in involves compiler-specific flags for modifying macro processing behaviour. This workaround breaks our existing test cases.

Hence, @numaru, could I please have an extension setting enabling me to tell the extension to use TEST_VALUE (or arbitrary string) instead of TEST_CASE? The same applies to TEST_RANGE.

numaru commented 2 years ago

I remember that someone might need to change the name of the macros as a workaround. 😋 Does the config proposed here could do the trick for you? https://github.com/ThrowTheSwitch/Ceedling/issues/241#issuecomment-775413905

olowo726 commented 2 years ago

This did not work for me since the compiler flag changes the processing of other macros we're using in our tests. Hence I could not used it but have to revert to the method of using TEST_VALUE instead of TEST_CASE. Hence I'm asking to be able to use TEST_VALUE (or arbitrary string from a setting) instead of TEST_CASE. I think this could be done perfectly backwards compatible by having the default value of the string being TEST_CASE.

Den lör 2 apr. 2022 kl 21:39 skrev Kin Numaru @.***>:

I remember that someone might need to change the name of the macros as a workaround. 😋 Does the config proposed here could do the trick for you? ThrowTheSwitch/Ceedling#241 (comment) https://github.com/ThrowTheSwitch/Ceedling/issues/241#issuecomment-775413905

— Reply to this email directly, view it on GitHub https://github.com/numaru/vscode-ceedling-test-adapter/issues/91#issuecomment-1086709269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK2BOGDJ4Y522TXSZDNCB3VDCO7BANCNFSM5RQIG62Q . You are receiving this because you authored the thread.Message ID: @.***>

numaru commented 2 years ago

Oh my bad, I missed the fact that they both use the same workaround :facepalm:. Ok I can look at it

olowo726 commented 2 years ago

Great, thanks!

On Sun, Apr 3, 2022, 10:16 Kin Numaru @.***> wrote:

Oh my bad, I missed the fact that they both use the same workaround 🤦. Ok I can look at it

— Reply to this email directly, view it on GitHub https://github.com/numaru/vscode-ceedling-test-adapter/issues/91#issuecomment-1086800932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK2BOE7NKVXOWK2YGQABULVDFHWHANCNFSM5RQIG62Q . You are receiving this because you authored the thread.Message ID: @.***>