numat / alicat

Python driver and command line tool for Alicat mass flow controllers.
GNU General Public License v2.0
21 stars 27 forks source link

command line does not work with TCP FlowControllers #21

Closed alexrudd2 closed 3 years ago

alexrudd2 commented 3 years ago

The FlowMeter class in tcp.py was ported from serial to TCP/IP and works ok. The FlowController class, which subclasses FlowMeter, was copied over and never modified.

Through luck, the positional arguments line up if instancing FlowController from Python code, except address is never passed and therefore defaults to A. However, this luck does not hold when using the command line.