Refactor to split interface/transport

numat / alicat

Python driver and command line tool for Alicat mass flow controllers.

GNU General Public License v2.0

21 stars 27 forks source link

Refactor to split interface/transport #37

Closed alexrudd2 closed 1 year ago

alexrudd2 commented 1 year ago

Switch fully to asyncio.
Setup linting and testing.
Split interface and transport layers
Closes #31
Closes #35
Closes #36

patrickfuller commented 1 year ago

Quick review. Only comment that matters is that I think the serial comm is still blocking. Don't know what the pattern to fix that today is, but it does fell weird for the end user to await commands that aren't async.

All other comments are pedantic one-offs and can be ignored.