Closed patrickfuller closed 2 years ago
This code was written for RS-232/USB support, and then the Ethernet gateway support was bolted on by copy-pasting the implementation.
This would be better organized as a Protocol-Transport model, where an abstract base class implements the protocol and stubs the transport.
Duplicate of #16.
patrickfuller
commented
2 years ago patrickfuller
commented
2 years ago
This code was written for RS-232/USB support, and then the Ethernet gateway support was bolted on by copy-pasting the implementation.
This would be better organized as a Protocol-Transport model, where an abstract base class implements the protocol and stubs the transport.