search

numat / mfc

Python driver and command line tool for MKS mass flow controllers.
GNU General Public License v2.0
8 stars 1 forks source link

Use aiohttp.ClientTimeout instead of deprecated read_timeout. #6

Closed alexrudd2 closed 2 years ago

alexrudd2 commented 2 years ago

Closes #5

patrickfuller commented 2 years ago

Looks good to me!

I don't know why asyncio moved to this pattern as it's messier than the old one, but that's outside the scope of this PR.

alexrudd2 commented 2 years ago

Looks good to me!

I don't know why asyncio moved to this pattern as it's messier than the old one, but that's outside the scope of this PR.

My guess is they wanted more granularity, since the new class allows for multiple timeout types. /shrug