Closed cooperlees closed 4 years ago
This is cool!
I don't think UI belongs in this repo (I'd like to keep this dedicated to simply reading the battery) but I'd be happy to link to it in the README. Let me know if you publish it and I'll add the hyperlink.
EDIT - I'm on board if this exporter is just exporting data in a different format. We don't even need to make it an extra. We could have a kwarg on get
or similar.
A prometheus exporter does just change the format, but it also runs a small http server for prometheus to come and scrape via HTTP at a period configured by the admin.
The extra dependency, prometheus_client, is the main reason I thought adding as an extra
would make sense so people who are using the library today don't pick up the extra dependency unless they actually want it.
Agreed. Exporting to a new data format belongs here, and an added dependency belongs in an extra
install. Happy to accept a PR here.
Thanks! Will polish it all up and make it solid before I put up the PR.
Would my prometheus_exporter, based on this module to pull data from my UPS, be accepted as an addition to this great module?
Dashboard I've built from the data collected: