Change withFiles method to return the Trix parent

numaxlab / nova-ckeditor5-classic

A Laravel Nova CKEditor5 Classic Field.

MIT License

39 stars 41 forks source link

Change withFiles method to return the Trix parent #2

Closed mbmultilaser closed 5 years ago

mbmultilaser commented 5 years ago

Return the Trix withFiles method to prevent "call_user_func() expects parameter 1 to be a valid callback, no array or string given" error in softDelete Models.

matkovsky commented 5 years ago

Uhm… what's happened here? 😄

We're running into the same issue, yet this PR — which apparently has fixed the issue — was closed unmerged.

What was the reason behind not merging this? Did this PR not fix the issue, or broke the package in other ways?

Thanks. 🙏

mbmultilaser commented 5 years ago

Unfortunately, I later realized this PR overrides TRIX custom functions, including tables created exclusively for this package to save attachments and use the default TRIX tables instead, for this reason I close.

Works for me, but need more work to merge. Sorry! :disappointed: