search

numba / llvmlite

A lightweight LLVM python binding for writing JIT compilers
https://llvmlite.pydata.org/
BSD 2-Clause "Simplified" License
1.94k stars 321 forks source link

Fix store to opaque ptr #1098

Open alexander-shaposhnikov opened 2 weeks ago

alexander-shaposhnikov commented 2 weeks ago

If ptr.type.is_opaque is True it doesn't need to have ptr.type.pointee attribute. Add a unit test.

sklam commented 1 week ago

@rj-jesus can you review this?

rj-jesus commented 1 week ago

@sklam Yep, sure. Thanks for the patch, @alexander-shaposhnikov. In general it LGTM, my only comment would be that the new test test_store could maybe be part of test_mem_ops, but I don't think this is critical.

alexander-shaposhnikov commented 1 week ago

Many thanks, I've updated the PR.

alexander-shaposhnikov commented 1 week ago

@sklam (would be amazing if you could merge this in, many thanks in advance)