search

numba / numba-integration-testing

Testing Numba 'master' against the latest released versions of dependent libraries.
BSD 2-Clause "Simplified" License
6 stars 11 forks source link

Fixup Datashader config #44

Closed esc closed 4 years ago

esc commented 4 years ago

Datashader needs some logic on the repo to determine what tag is the latest release.

esc commented 4 years ago

Title was updated to reflect that more changes to the datashader config have to be made.

esc commented 4 years ago

@philippjfr I'm not sure about this one, the code to determine the correct version seems unnecessarily complex.

philippjfr commented 4 years ago

I'm not sure about this one, the code to determine the correct version seems unnecessarily complex.

Agreed let's just delete the non-conforming tags, i.e. website and website-dev, that should solve it automatically right?

philippjfr commented 4 years ago

I've deleted them now.

esc commented 4 years ago

I think that will not suffice, unfortunately. We still need to deal with parsing and comparing the major, minor, patch and alpha version numbers and sorting accordingly. Maybe https://pypi.org/project/packaging/ can do this for us? I'd have to check it out.

esc commented 4 years ago

So I tried using packaging it seems to work quite well for this case.

esc commented 4 years ago

Some of the Datashader failures are related to this issue in Numba:

https://github.com/numba/numba/issues/5570

esc commented 4 years ago

oh wow, datashader passed! Let's get this in!