search

numba / numba-integration-testing

Testing Numba 'master' against the latest released versions of dependent libraries.
BSD 2-Clause "Simplified" License
6 stars 11 forks source link

Feature request: make `git_latest_tag` work with CalVer release schemes #78

Open epassaro opened 2 years ago

epassaro commented 2 years ago

A few months ago I noticed that git_latest_tag does not work as expected for CalVer releases. Seems to work just for semantic versions.

esc commented 2 years ago

A few months ago I noticed that git_latest_tag does not work as expected for CalVer releases. Seems to work just for semantic versions.

this is correct yes, pull-requests are welcome.

esc commented 2 years ago

@epassaro thank you for raising this. I have converted it into a feature request.

epassaro commented 2 years ago

The two workarounds I found months ago were:

  1. Update git on CircleCI to use git describe --tags --abbrev=0
  2. Get the latest tag from the GitHub API

Is any of these two options good enough? I think the second probably not.