search

numba / numba-rvsdg

Numba compatible RVSDG (Regionalized Value State Dependence Graph) utilities.
https://numba-rvsdg.readthedocs.io/
BSD 2-Clause "Simplified" License
18 stars 7 forks source link

Refactor: Make `jump_target` a property of SCFG #73

Open kc611 opened 1 year ago

kc611 commented 1 year ago

The attribute jump_target of BasicBlock class is mutated over the course of various transformations, this leads to the blocks being rebuilt and the SCFG being deep copied every time a transformation is applied.

It should be made a mutable property of the SCFG class instead of an immutable property of the BasicBlock frozen data class. This will prevent unnecessary copies.

guilhermeleobas commented 1 year ago

Hi @kc611, is this somehow related to #58? Or this issue is open for someone to work on?

kc611 commented 1 year ago

Yes, it is what #58 was made to resolve. I'll link the issue shortly.