Closed esc closed 1 year ago
After some OOB conversations with @sklam -- it was discovered that on a clean/pristine checkout of this PR the conda package building failed. Specifically (...
indicates that some log output was truncated for readability):
$ conda-build conda-recipes/
...
+ pytest --pyargs numba_rvsdg
============================= test session starts ==============================
platform darwin -- Python 3.11.4, pytest-7.4.0, pluggy-1.0.0
rootdir: $SRC_DIR
collected 0 items
============================ no tests ran in 0.00s =============================
...
TESTS FAILED: numba_rvsdg-0.0.2-46_gac7f5dfa83.tar.bz2
As @sklam identified, nothing was actually installed during the pip install
stage. Furthermore the changes at:
https://github.com/numba/numba-rvsdg/commit/aae96c763e4e5488532198229ce88f71c6f61775
were overwritten by the changes at:
which means that the automatic package discovery was bust.
Using the patch at:
diff --git i/pyproject.toml w/pyproject.toml
index f08cfb1f63..6975b372bc 100644
--- i/pyproject.toml
+++ w/pyproject.toml
@@ -22,8 +22,8 @@ dependencies = [
"pyyaml",
]
-[tool.setuptools]
-packages = ["numba_rvsdg"]
+[tool.setuptools.packages]
+find = {}
[project.optional-dependencies]
dev = [
... will re-enable the conda package building, so I am adding that patch to this PR now.
This updates the
conda
recipe using out from thegrayskull
tool:https://github.com/conda/grayskull
The basic procedure was to first generate an
sdist
using:pipx run build --sdist
.. as suggested by
.github/workflows/release.yml
.This resulted in the follwing:
I then took the most important things, which were how to build a
noarch
package and using thescript
directive and spliced them into the current recipe inconda-recipes/meta.yaml
.I then also updated the
build/string
attribute.Here is a log:
As you can see, the resulting package is both
noarch
and includes the current git info in it's build-string (and not the version number):