search

numbas / Numbas

A completely browser-based e-assessment/e-learning system, with an emphasis on mathematics
http://www.numbas.org.uk
Apache License 2.0
200 stars 118 forks source link

Diagnosys: Add a finish action when you are retrying the last question. #867

Closed jhoobergs closed 2 years ago

jhoobergs commented 2 years ago

Currently when you are retrying the last question, there is only one action: the retry, which is then automatically executed and gives a strange flickery effect without the student really knowing what happened. This PR adds a stop action which stops the exam by not setting a next question. This implies that there are 2 possible actions in the end, which prevents the flickery effect by letting the student decide whether to retry or not. It also fixes the next_diagnostic_question which didn't check for null.

jhoobergs commented 2 years ago

@christianp Any comment on this? (no hurry :) )

christianp commented 2 years ago

Sorry it took me so long to look at this! This change seems good, and I've merged it. I made the text "End the test" translatable.