numbas / Numbas

A completely browser-based e-assessment/e-learning system, with an emphasis on mathematics
http://www.numbas.org.uk
Apache License 2.0
200 stars 118 forks source link

Save to store when ending a diagnostic test #887

Closed jhoobergs closed 2 years ago

jhoobergs commented 2 years ago

Diagnostic tests that are ended when there are no more topics, don't seem to get the completed status in our lti provider.

I haven't tested this change, but I guess this could be the solution?

Might be related to https://github.com/numbas/numbas-lti-provider/issues/143

christianp commented 2 years ago

Thanks. It's unlikely that this is related to numbas/numbas-lti-provider#143 because we haven't actually used diagnostic mode with students yet!

There's another way of ending an exam in diagnostic mode, when the algorithm produces no "next question" actions, which might be what you actually encountered. I've changed that too.