search

numbas / editor

An editor for the Numbas e-learning system.
http://numbas.mathcentre.ac.uk
Apache License 2.0
59 stars 61 forks source link

display of sets in variable preview is sometimes too long #439

Closed christianp closed 5 years ago

christianp commented 5 years ago

I have a feeling I've recently done the opposite of what I'm about to propose: when the string rendering of a set is too long, the preview should instead say something like "set of N items", similar to how lists are displayed.

JoshuaCapel commented 5 years ago

I think I have resolved this with pull request: https://github.com/numbas/editor/pull/443

christianp commented 5 years ago

Thanks! I've merged it in. For future reference: it makes my life easier if you create a separate branch for each pull request. That way, if you have more than one pull request open at once, I can merge them separately.

JoshuaCapel commented 5 years ago

Okay, I will make sure to branch in the future.

On 17 Dec 2018, at 9:44 pm, Christian Lawson-Perfect notifications@github.com wrote:

Thanks! I've merged it in. For future reference: it makes my life easier if you create a separate branch for each pull request. That way, if you have more than one pull request open at once, I can merge them separately.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.