Closed christianp closed 2 years ago
Hello, I would like to take up this task. Could you also give some pointers on how exactly you want the header to look like, as OK is a bit ambiguous .
@sarthak0699 thanks for offering to help. I don't really have anything in mind, I just think it's not very attractive at the moment!
@christianp I am working on this. i will share the image of preview banner once completed.
Hi @christianp , Can you pls let me know if the below changes looks fine, If yes, i will then create a pull request. Please let me know if incase of any suggestions.
@Maheshwaran17 that looks good, thanks!
How small is the text? It shouldn't be any smaller than 16px, for accessibility. I think just reducing the padding would be enough.
What do you use to copy the URL to the clipboard? I think the URL could also still be displayed, rather than having the text change back after 1 second.
I like how you show the licence, and that the links on the right aren't underlined.
I don't think "Q:" before the question name is particularly helpful.
Hi @christianp , Thank you for the reply.
I have made the below changes and attached the images below for your reference.
Please let me know if you are happy with this look or let me know if in case of any corrections. I will submit the pull request based on your comment. Thanks in advance!
That looks better, thanks. It's still not great for accessibility for the URL to disappear automatically. Apart from that, it all looks good!
When you test run a question or exam, it's shown in a page with a banner across the top, showing links to edit, download or share the item. At the moment, it doesn't have much styling:
I'd like it to look a little bit nicer. The page doesn't load the bootstrap styles used by the rest of the site; maybe it should.
<code>
tag showing the URL, which it would ideally copy to the clipboard.