numbas / numbas-lti-provider

An LTI tool provider to run Numbas exams
https://docs.numbas.org.uk/lti/en/latest/
Other
11 stars 12 forks source link

SEB on mac: quit link not working on mac (any mac version) #281

Closed Spruce8913 closed 1 year ago

Spruce8913 commented 1 year ago

When clicked on mac, receives the error message "you were not supposed to see this". The button "Go Back" then does not respond to clicks. This is on SEB version 3.2.5 and many different versions of mac (in exam hall of 100 students the quit link was not working for anyone with a mac, around 50 students).

mjmq100 commented 1 year ago

I see this with SEB 3.2.5 on macOS 13.5.2 and v3.2 of the LTI provider. I think SEB is looking for an exact match for the quit URL supplied in its config, but the provider tacks on a resource_link_id query parameter when generating the URL from within an attempt. (Generated in numbas_lti/context_processors.py I think, but it seems the parameter is added in middleware?).

To test this, in my SEB config file I appended a query string to the quit URL to include the resource_link_id associated with my test. With this the quit URL works.

I can imagine some ugly workarounds, but I'm not sure what a robust solution would be.

christianp commented 1 year ago

It was indeed the resource_link_id query parameter that the mac version of SEB doesn't like. I think this is a bug in SEB, if the windows version can cope with it.

The parameter isn't needed, anyway, so I've changed it so that the Numbas LTI tool doesn't add the resource_link_id parameter to the URL